Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.3.3 #74

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Release/0.3.3 #74

merged 3 commits into from
Oct 5, 2023

Conversation

picciama
Copy link
Contributor

@picciama picciama commented Oct 3, 2023 •
edited
Loading

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Don't fail on unknown mass analyzer when reading mzml file.

Technical details

removed raising an error

Additional context

@picciama picciama requested a review from LLautenbacher October 3, 2023 14:14
@picciama picciama merged commit 42ecdfb into main Oct 5, 2023
36 checks passed
@picciama picciama deleted the release/0.3.3 branch November 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLautenbacher LLautenbacher LLautenbacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picciama @LLautenbacher